[nodebb-plugin-link-preview] Rich Embeds and Link Previews
-
julian@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
Release v1.1.0
- A framework for "special embeds" was built out, and a couple defaults added in. A special embed would be one where a third-party provides a preferred embed code for use instead of the default box that ships with this plugin.
- YouTube and Vimeo are the built-in defaults, but additional ones can be added fairly easily.
- There is also a new ACP interface that builds upon commits in v3.2.x, so that is the new minimum version required.
-
frankm@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
Thanks @julian for this plugin.
I have deactivate my iframely plugin and test your plugin.
There must be a blank line above the link. Is that the way you want it? When there isn't an blank line we got no preview. Which is not so bad, see the example
And what i don't need is an preview in this code.
Sources: * Link1 * Link2 and so on
-
julian@community.nodebb.organtwortete auf frankm@community.nodebb.org am zuletzt editiert von
@FrankM the former is correct. I didn't want it to automatically capture and unfurl anchors within paragraph text, so it needs to be a link all on its own, without custom anchor text.
The latter re: list items is a valid bug, I'll have to fix that @baris also pointed it out to me yesterday
-
josef@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian It's quite confusing that clicking on the image opens the image in a new tab, instead of the link itself...
I don't think this is expected behavior, the expected behavior is that clicking on the image opens the link, and those who want to view the image enlarged will right-click > open image in a new tab -
julian@community.nodebb.organtwortete auf josef@community.nodebb.org am zuletzt editiert von
@josef I agree! I'll look into making this change. It's not something the ntfy plugin does, but rather core automatically wrapping images in links.
-
josef@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian ntfy plugin? What does it have to do with nodebb-plugin-link-preview?
-
julian@community.nodebb.organtwortete auf josef@community.nodebb.org am zuletzt editiert von
@josef sorry, I meant link-preview
-
baris@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian if you wrap the image with an anchor tag then the wrap code in core will ignore it https://github.com/NodeBB/NodeBB/blob/master/public/src/client/topic/images.js#L21
-
julian@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
Thanks @baris — this is now done on v1.1.1
-
torn2@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
Will this be updated to have the player in the card, instead of having to click on it and then go to YouTube?
- YouTube
Auf YouTube findest du die angesagtesten Videos und Tracks. Außerdem kannst du eigene Inhalte hochladen und mit Freunden oder gleich der ganzen Welt teilen.
(www.youtube.com)
Edit: :voodoo: just editing to regenerate the preview - @julian
-
julian@community.nodebb.organtwortete auf torn2@community.nodebb.org am zuletzt editiert von
@torn2 yes, that's available now, but I'm guessing the plugin isn't updated on this forum yet
-
baris@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian this forum is running
1.1.1
:think: -
julian@community.nodebb.organtwortete auf baris@community.nodebb.org am zuletzt editiert von
@baris well... That's not good then
Ah, the YouTube special embed just wasn't turned on here.
-
torn2@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian Awesome, thanks!
-
pitaj@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
The YouTube embed overflows on mobile, causing the page to have empty space to the right. Probably needs a max-width.
-
torn2@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
Is there a setting to turn on embeds? It will not embed YouTube now that I changed to 3.2.2
-
julian@community.nodebb.organtwortete auf torn2@community.nodebb.org am zuletzt editiert von
@torn2 the plugin is configurable via the ACP. Including the YouTube embed.
-
torn2@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian said in [nodebb-plugin-link-preview] Rich Embeds and Link Previews:
@torn2 the plugin is configurable via the ACP. Including the YouTube embed.
Wher in the ACP do we find the settings for this? I do not see it in the plugin as any settings available for this plugin.
-
julian@community.nodebb.organtwortete auf torn2@community.nodebb.org am zuletzt editiert von
@torn2 under the "plugins" submenu is the option for the link preview plugin. You're in the plugins page under "extend"
-
torn2@community.nodebb.organtwortete auf julian@community.nodebb.org am zuletzt editiert von
@julian said in [nodebb-plugin-link-preview] Rich Embeds and Link Previews:
@torn2 under the "plugins" submenu is the option for the link preview plugin. You're in the plugins page under "extend"
JA! It was missing at first!